Been playing some more (on the delmarva map) and gotta say it really captures the feel of the ACW. All the fixes are great and it runs smoothly.
One possible enhancement I've come up with was when I noticed that the music.cfg macro seems to be adding music tracks at start based on which factions are playing. The log shows a duplicate warning if you have more than 2 sides (like 4 CSA & 4 USA sides like in Delmarva) because it is adding them in 4 times for each sides. Nothing broken but it made me wonder why it was like that since the era has only 2 factions and logically you'd always simply use all the tracks because it's always those 2 sides.
So I remade that macro to do what it seemed to be suggesting: That it loads each faction's music during their own turn.
So here it is:Tried it out and it appears to work (short turns though don't really let one hear much) with Dixieland playing when the CSA has its turn and Star Spangled Banner when the USA does. It is random too, I just mention those since they're obvious. I tried it on Inanna's Oasis in Freeze which has a 7th "monster" side to try and hear if they in fact played the last 4 "else" tracks that seemed to be designated for non-ACW factions. Alas the monster turns flew by too quickly to hear anything (takes a bit for a track to queue up and start playing - BfW has a built in delay, have a look at the core macros sometime : ) ) but I suppose it should be working too.
One possible enhancement I've come up with was when I noticed that the music.cfg macro seems to be adding music tracks at start based on which factions are playing. The log shows a duplicate warning if you have more than 2 sides (like 4 CSA & 4 USA sides like in Delmarva) because it is adding them in 4 times for each sides. Nothing broken but it made me wonder why it was like that since the era has only 2 factions and logically you'd always simply use all the tracks because it's always those 2 sides.
So I remade that macro to do what it seemed to be suggesting: That it loads each faction's music during their own turn.
So here it is:
Code:
#define MUSIC_CW[event] name=side_turn first_time_only=no {REPLACE_SCENARIO_MUSIC silence.ogg} [store_side] side=$side_number [/store_side] [switch] variable=side.faction [case] value="CSA" {APPEND_MUSIC The-Bonnie-Blue-Flag.ogg} {APPEND_MUSIC Dixiland.ogg} {APPEND_MUSIC Kellys-Irish-Brigade.ogg} {APPEND_MUSIC When-Johnny-Comes-Marching-Home.ogg} [/case] [case] value="USA" {APPEND_MUSIC Star-Spangled-Banner.ogg} {APPEND_MUSIC 111th-New-York.ogg} {APPEND_MUSIC The-Battle-Cry-of-Freedom.ogg} {APPEND_MUSIC Fife-And-Drum.ogg} [/case] [else] {APPEND_MUSIC Hell-on-the-Wabash.ogg} {APPEND_MUSIC figght.ogg} {APPEND_MUSIC battle_theme.ogg} {APPEND_MUSIC Facing_the_Front.ogg} [/else] [/switch][/event]#enddefStatistics: Posted by Atreides — Yesterday, 11:31 pm